Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a new SuperProperties Object #95

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

BillCarsonFr
Copy link
Member

Add a new SuperProperties object to formalize the properties that can be added to all events

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this 🙏

@@ -0,0 +1,28 @@
{
"type": "object",
"description": "Super Properties are properties associated with events that are set once and then sent with every capture call, be it a $pageview, an autocaptured button click, or anything else.",
Copy link
Member

@pixlwave pixlwave Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should reword the set once bit to avoid confusion with $set_once given these super properties are separate from user properties?

@BillCarsonFr BillCarsonFr merged commit 446c42e into main Mar 26, 2024
3 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/super_properties branch March 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants