Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mobile interaction events for favouriting rooms from the room list and r… #89

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add mobile interaction events for favouriting rooms from the room list and r… #89

merged 1 commit into from
Feb 19, 2024

Conversation

stefanceriu
Copy link
Member

…oom detail screens

@stefanceriu stefanceriu requested a review from a team as a code owner February 19, 2024 10:39
@stefanceriu stefanceriu changed the title Add interaction events for favouriting rooms from the room list and r… Add mobile interaction events for favouriting rooms from the room list and r… Feb 19, 2024
t3chguy
t3chguy reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web also has both of those interactions, maybe they shouldn't be mobile specific for more coherent analytics?

@stefanceriu
Copy link
Member Author

Web also has both of those interactions, maybe they shouldn't be mobile specific for more coherent analytics?

Well I thought about that but they're very funkily named WebRoomListRoomTileContextMenuFavouriteToggle and WebRoomHeaderContextMenuFavouriteToggle. Would you prefer I make mine super generic and you update yours eventually? Can I mark these things as deprecated in any way?

t3chguy
t3chguy approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebRoomHeaderContextMenuFavouriteToggle

should probably be untouched, unless Mobile has the same room header ctx menu interaction

given the historic data on WebRoomListRoomTileContextMenuFavouriteToggle it probably doesn't make sense to rename

@stefanceriu stefanceriu merged commit 354562b into main Feb 19, 2024
3 checks passed
@stefanceriu stefanceriu deleted the stefan/mobileRoomFavouriting branch February 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @t3chguy @ganfra