Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interaction type for making room list rooms as unread or favourite #88

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add interaction type for making room list rooms as unread or favourite #88

merged 1 commit into from
Feb 6, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Feb 2, 2024 •
edited
Loading

This PR introduced a new interaction type for tracking marking rooms as (un)read

@stefanceriu stefanceriu requested a review from a team as a code owner February 2, 2024 10:59
@stefanceriu stefanceriu requested a review from bmarty February 2, 2024 10:59
bmarty
bmarty approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking merge, but some remarks.

schemas/Interaction.json Outdated Show resolved Hide resolved
@stefanceriu stefanceriu force-pushed the stefan/markUnreadAndFavorite branch from 28d1e65 to 6644427 Compare February 6, 2024 15:22
@stefanceriu stefanceriu merged commit ad2b2d2 into main Feb 6, 2024
3 checks passed
@stefanceriu stefanceriu deleted the stefan/markUnreadAndFavorite branch February 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @bmarty