Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist/blacklist maintenance complainer to buildkite annotations #870

Merged
merged 10 commits into from
Feb 14, 2020

Conversation

anoadragon453
Copy link
Member

The complainer's output appears like this now:

image

Instead of you having to dig through the long list of logs.

Required associated SyTest PR: matrix-org/sytest#803

@anoadragon453 anoadragon453 requested a review from a team February 14, 2020 11:13
Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible 💃

@anoadragon453
Copy link
Member Author

Oops, it's not. The newlines in the output are borked. Dangit xargs.

Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks totally insane, I can't believe you did that with xargs :D

@anoadragon453
Copy link
Member Author

Well, that's better. But we still have a failing test.

Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful, I'm in awe of how you tamed xargs 🥳

@anoadragon453 anoadragon453 merged commit 409fec2 into master Feb 14, 2020
@anoadragon453 anoadragon453 deleted the anoa/dendrite_whitelist_annotation branch February 14, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants