This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Optimize PrevEventIDs when getting thousands of backwards extremeties
#3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
==========================================
- Coverage 65.50% 65.34% -0.16%
==========================================
Files 509 509
Lines 57493 57514 +21
==========================================
- Hits 37659 37585 -74
- Misses 15960 16030 +70
- Partials 3874 3899 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
kegsay
suggested changes
Jan 19, 2024
roomserver/api/perform.go
Outdated
| } | ||
| prevEventIDs = util.UniqueStrings(prevEventIDs) | ||
| // If we still have > 100 eventIDs, only return the first 100 | ||
| if len(prevEventIDs) > 100 { | ||
| return prevEventIDs[:100] |
There was a problem hiding this comment.
Again, arbitrary and needs justification. Also need to justify why we just spent all this time getting 1000 only to take 100 of them. At what point would a map[string]struct{} be better than this?
There was a problem hiding this comment.
Looks like map[string]struct{} has the best results - 1 more alloc compared to the "original" change and otherwise much better, see updated PR description.
…ckfill-prev-eventIDs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how many
PrevEventIDswe send to other servers when backfilling, capped to 100 events.Unsure about how representative this benchmark is..