-
-
Notifications
You must be signed in to change notification settings - Fork 677
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
==========================================
- Coverage 65.53% 65.52% -0.01%
==========================================
Files 509 509
Lines 57514 57522 +8
==========================================
Hits 37694 37694
- Misses 15951 15959 +8
Partials 3869 3869
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we also want to do this here as well:
dendrite/federationapi/routing/routing.go
Line 648 in bebf701
hub := sentry.GetHubFromContext(req.Context()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be doing a similar thing everywhere we use CaptureException or CaptureMessage?
The docs would suggest we should (at least everywhere being run inside a goroutine) https://docs.sentry.io/platforms/go/usage/concurrency/
Created #3306 as a follow up task |
This hopefully reduces the garbage we currently produce.
(Using GlitchTip on my personal instance, this seems to look better)