Exclude old state events from sync when consumed from roomserver #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell, the sytests that this has caused to fail probably shouldn't have been passing before. The sync API doesn't currently have the ability to insert events into the history of the timeline - they can only get added as if they had just happened - and I get the feeling this has caused us to pass a couple of tests by fluke. |
Concerns from the peanut gallery: If I send dendrite an extremely delayed transaction from my HS, containing events from ages ago, will the sync API treat those as new? |
kegsay
approved these changes
Oct 22, 2020
neilalexander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consuming old room events from the roomserver, the sync API was not excluding them from sync, which I think is responsible for some older events appearing incorrectly in the timeline. This should therefore fix #1547.