Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for new transaction ID scope after MSC3970 was merged in Matrix 1.7 #637

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

hughns
Copy link
Member

@hughns hughns commented May 26, 2023

This adds tests for the new transaction ID semantics that were part of MSC3970 and are now part of 1.7 of the Matrix spec.

Note that some of the tests are skipped because neither Synapse not Dendrite implement the new semantics by default yet.

Pull Request Checklist

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

@hughns hughns requested review from a team and kegsay as code owners May 26, 2023 16:44
This was referenced May 26, 2023
@hughns hughns changed the title Test for new transaction ID scope after MSC3970 was merged Test for new transaction ID scope after MSC3970 was merged in Matrix 1.7 May 26, 2023
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, it will need 768f359 cherry-picked onto it before merge.

@clokep clokep removed request for a team and kegsay May 30, 2023 18:07
@DMRobertson
Copy link
Contributor

it will need 768f359 cherry-picked onto it before merge.

This seems to have happened, so I am merging.

@DMRobertson DMRobertson merged commit b986a30 into matrix-org:main Aug 7, 2023
4 checks passed
@clokep
Copy link
Member

clokep commented Aug 7, 2023

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants