Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /v3 URLs instead of /r0 #411

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Use /v3 URLs instead of /r0 #411

merged 4 commits into from
Jul 14, 2022

Conversation

neilalexander
Copy link
Contributor

We had quite a lot of tests still using /r0 URLs.

@neilalexander neilalexander requested review from kegsay and richvdh July 13, 2022 11:35
@neilalexander neilalexander mentioned this pull request Jul 13, 2022
Merged
richvdh
richvdh approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than comment tweak

internal/federation/handle.go Outdated Show resolved Hide resolved
@neilalexander @richvdh
Update internal/federation/handle.go
1416c9c 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@neilalexander neilalexander merged commit 086fa4b into main Jul 14, 2022
@neilalexander neilalexander deleted the neilalexander/v3 branch July 14, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@kegsay kegsay Awaiting requested review from kegsay kegsay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilalexander @richvdh