Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt MSC2716 implementation to use chunk events #168

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Adapt MSC2716 implementation to use chunk events #168

merged 2 commits into from
Jul 23, 2021

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jul 20, 2021 •
edited
Loading

@MadLittleMods MadLittleMods force-pushed the madlittlemods/synapse-10432-switch-to-chunk-events branch from e3635f9 to 829839f Compare July 20, 2021 05:08
@MadLittleMods MadLittleMods requested a review from kegsay July 22, 2021 19:48
MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Jul 22, 2021
@MadLittleMods
Disable msc2716 until Complement update is merged
b5ce893 
Disable msc2716 tests until both the Complement and Synapse PRs
are merged.

Currently #10432 is merged
but is still open matrix-org/complement#168
which relies on the changes.

Unfortunately, we would run into this situation if either side was merged too.
@MadLittleMods MadLittleMods mentioned this pull request Jul 22, 2021
Merged
4 tasks
kegsay
kegsay approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this chunk event is made in Synapse and not by the client.

@MadLittleMods
Copy link
Contributor Author

I assume this chunk event is made in Synapse and not by the client.

Correct, it's automatically added when using the /batch_send endpoint 👍

@MadLittleMods MadLittleMods merged commit eff9d80 into master Jul 23, 2021
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @kegsay 🐄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kegsay kegsay kegsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @kegsay