fix(deps): Remove dependency org.glassfish.web:el-impl

There is no need for this dependency. An el-impl is already provided by Spring Boot/tomcat-embed-el. tomcat-embed-el is also used for other servlet containers. Related: spring-projects/spring-boot#24744
matrei · Feb 26, 2024 · 3cea2bd · 3cea2bd
1 parent 954ef75
commit 3cea2bd
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java b/grails-forge-core/src/main/java/org/grails/forge/feature/database/HibernateGorm.java
@@ -91,10 +91,6 @@ public void apply(GeneratorContext generatorContext) {
                 .groupId("org.hibernate")
                 .lookupArtifactId("hibernate-core")
                 .compile());
-        generatorContext.addDependency(Dependency.builder()
-                .groupId("org.glassfish.web")
-                .lookupArtifactId("el-impl")
-                .runtime());
         generatorContext.addDependency(Dependency.builder()
                 .groupId("org.apache.tomcat")
                 .artifactId("tomcat-jdbc")

diff --git a/grails-forge-core/src/main/resources/pom.xml b/grails-forge-core/src/main/resources/pom.xml
@@ -17,11 +17,6 @@
             <artifactId>hibernate-core</artifactId>
             <version>5.6.15.Final</version>
         </dependency>
-        <dependency>
-            <groupId>org.glassfish.web</groupId>
-            <artifactId>el-impl</artifactId>
-            <version>2.2.1-b05</version>
-        </dependency>
         <dependency>
             <groupId>javax.xml.bind</groupId>
             <artifactId>jaxb-api</artifactId>

diff --git a/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy b/grails-forge-core/src/test/groovy/org/grails/forge/feature/database/HibernateGormSpec.groovy
@@ -30,7 +30,6 @@ class HibernateGormSpec extends ApplicationContextSpec implements CommandOutputF
         then:
         template.contains('implementation("org.grails.plugins:hibernate5")')
         template.contains('implementation("org.hibernate:hibernate-core:5.6.15.Final")')
-        template.contains("runtimeOnly(\"org.glassfish.web:el-impl:2.2.1-b05\")")
         template.contains("runtimeOnly(\"org.apache.tomcat:tomcat-jdbc\")")
         template.contains("runtimeOnly(\"com.h2database:h2\")")
         template.contains("runtimeOnly(\"javax.xml.bind:jaxb-api:2.3.1\")")