-
Notifications
You must be signed in to change notification settings - Fork 0
Add commented out run-build and run-command step to generated workflow #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
public/scripts/workflow.js
Outdated
- name: Set up MATLAB | ||
uses: matlab-actions/setup-matlab@v2 | ||
with: | ||
# Set up additional products using the 'products' input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike run-build, run-command, and MLM_LICENSE_TOKEN, products is quoted here.
Can we be consistent? If you like to show these as literal values, enclose them in backtips (``) instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you feel about just removing the quotes on products?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should works.
public/scripts/workflow.js
Outdated
# with: | ||
# tasks: test | ||
|
||
# Use run-command to run MATLAB scripts, functions, and statements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the run-command action?
public/scripts/workflow.js
Outdated
- name: Run MATLAB tests | ||
uses: matlab-actions/run-tests@v2 | ||
|
||
# Use run-build to invoke the MATLAB build tool if you have a buildfile.m. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the run-build action to run the tasks in your build file named buildfile.m?
(Try to avoid "invoke" and "a buildfile.m")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the run-build action to run the tasks in your buildfile.m?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
This change adds a commented out
run-build
andrun-command
step to all generated workflows.I experimented with giving an option for choosing the type of step you what to use on the generator webpage, but it complicated the simple one-field, one-button, interface I would like to maintain.
Note the
README.md
is touched because prettier is auto-formatting it. I prefer just having prettier maintain all formatting in this repo so we don't have to worry about it.A generated workflow with all options now looks like this: