Move ensuring existence of directories for configuration files to Con…

…figurationAttributeBase
matkoch · Nov 9, 2019 · 9c5b5ab · 9c5b5ab
1 parent 790ab9e
commit 9c5b5ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/source/Nuke.Common/CI/ConfigurationAttributeBase.cs b/source/Nuke.Common/CI/ConfigurationAttributeBase.cs
@@ -14,6 +14,7 @@
 using Nuke.Common.Tools.DotNet;
 using Nuke.Common.Utilities;
 using Nuke.Common.Utilities.Collections;
+using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.IO.PathConstruction;
 
 namespace Nuke.Common.CI
@@ -58,10 +59,12 @@ public void OnAfterLogo(
             if (!AutoGenerate || NukeBuild.IsServerBuild)
                 return;
 
+            GeneratedFiles.ForEach(EnsureExistingParentDirectory);
+
             Logger.LogLevel = LogLevel.Trace;
             var previousHashes = GeneratedFiles
                 .Where(File.Exists)
-                .ToDictionary(x => x, FileSystemTasks.GetFileHash);
+                .ToDictionary(x => x, GetFileHash);
 
             var assembly = Assembly.GetEntryAssembly().NotNull("assembly != null");
             ProcessTasks.StartProcess(
@@ -72,7 +75,7 @@ public void OnAfterLogo(
                 .AssertZeroExitCode();
 
             var changedFiles = GeneratedFiles
-                .Where(x => FileSystemTasks.GetFileHash(x) != previousHashes.GetValueOrDefault(x))
+                .Where(x => GetFileHash(x) != previousHashes.GetValueOrDefault(x))
                 .Select(x => GetRelativePath(NukeBuild.RootDirectory, x)).ToList();
 
             if (changedFiles.Count > 0)
@@ -96,7 +99,7 @@ public void OnBuildFinished(NukeBuild build)
 
         private string GetCurrentHash()
         {
-            return GeneratedFiles.Select(FileSystemTasks.GetFileHash).JoinComma();
+            return GeneratedFiles.Select(GetFileHash).JoinComma();
         }
 
         protected abstract HostType HostType { get; }

diff --git a/source/Nuke.Common/Utilities/CustomFileWriter.cs b/source/Nuke.Common/Utilities/CustomFileWriter.cs
@@ -18,7 +18,6 @@ public class CustomFileWriter : IDisposable
 
         public CustomFileWriter(string filename, int indentationFactor, FileMode fileMode = FileMode.Create)
         {
-            FileSystemTasks.EnsureExistingParentDirectory(filename);
             _fileStream = File.Open(filename, fileMode);
             _streamWriter = new StreamWriter(_fileStream);