Custom ERC1155Predicate with generic ChainExit event

[itzmeanjan]

What's new ?

Custom ERC1155Predicate with ChainExit event based on description : https://github.com/thesandboxgame/sandbox-smart-contracts/blob/doc/matic-predicate/documentation/drafts/matic/chain_exit_erc1155_predicate.md

[nfurfaro]

Hello. I think a small change which makes this new event even more useful & generic would be to modify the types of 2 of the ChainExit event params to be arrays. So the new event would look like this:
ChainExit(address indexed to, uint256[] tokenIds, uint256[] amounts, bytes data)
This would let allow for both batch or single chain-exits. As it is currently written, this new predicate was creating arrays out of the single tokenId & amount anyway prior to calling token.mintBatch(...

[itzmeanjan]

Hello. I think a small change which makes this new event even more useful & generic would be to modify the types of 2 of the ChainExit event params to be arrays. So the new event would look like this:
ChainExit(address indexed to, uint256[] tokenIds, uint256[] amounts, bytes data)
This would let allow for both batch or single chain-exits. As it is currently written, this new predicate was creating arrays out of the single tokenId & amount anyway prior to calling token.mintBatch(...

This is WIP. Thanks.

[itzmeanjan]

Hello. I think a small change which makes this new event even more useful & generic would be to modify the types of 2 of the ChainExit event params to be arrays. So the new event would look like this:
ChainExit(address indexed to, uint256[] tokenIds, uint256[] amounts, bytes data)
This would let allow for both batch or single chain-exits. As it is currently written, this new predicate was creating arrays out of the single tokenId & amount anyway prior to calling token.mintBatch(...

This is attached in PR.

[imyourm8]

Return bool flag if there is any token that should be minted, to avoid the unnecessary call to external contract.

[imyourm8]

You can return a second bool flag, that indicates that tokens are only minted to avoid unnecessary transferFrom entirely in some cases.

[itzmeanjan]

Done : 404745e

[imyourm8]

There are other artifacts that are committed, like MintableERC115Predicate, let's files only for the ChainExit predicate.

[itzmeanjan]

There are other artifacts that are committed, like MintableERC115Predicate, let's files only for the ChainExit predicate.

Done : 16b832a

[mvanmeerbeck]

Hi there,

What's the state of this PR ? It is still required for Sandbox

Thanks!

[itzmeanjan]

Deployment in progress, I'm merging it.