Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SubscribeFullPendingTransactions from go-ethereum #884

Closed
wants to merge 2 commits into from

Conversation

yuichiroaoki
Copy link

Description

This enables the full transaction body subscription, SubscribeFullPendingTransactions.
It was implemented in go-ethererum with this
PR(ethereum/go-ethereum#25186).

You can find the whole conversation regarding this issue here (ethereum/go-ethereum#24524).

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

yuichiroaoki and others added 2 commits June 1, 2023 22:02
This enables the full transaction body subscription, which was already
implemented in go-ethererum with this
PR(ethereum/go-ethereum#25186)
@manav2401
Copy link
Contributor

Hey, thanks for raising the PR. We're already working on merging the upstream changes from geth and this change will be accounted in it. Closing this for now, thanks!

@manav2401 manav2401 closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants