Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth, consensus: refactor whitelisting related logs and improve error handling #1268

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

manav2401
Copy link
Contributor

Description

This PR refactors logs revolving around checkpoint/milestone whitelisting. Mainly, it attempts to remove redundant logs and adjust the verbosity based on their priority and frequency.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 requested a review from a team June 13, 2024 09:23
@marcello33
Copy link
Contributor

There could be smth that broke this unit test: TestFetchWhitelistCheckpointAndMilestone

@manav2401
Copy link
Contributor Author

There could be smth that broke this unit test: TestFetchWhitelistCheckpointAndMilestone

Thanks, addressed them. Will wait for CI to re-run.

@manav2401 manav2401 changed the base branch from develop to 1.3.4-candidate June 18, 2024 05:18
@manav2401 manav2401 merged commit 2fd85b3 into 1.3.4-candidate Jun 18, 2024
8 of 9 checks passed
@manav2401 manav2401 deleted the manav/refactor-logs branch June 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants