-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Changes reverted in PR#1124 #1204
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.3.0-beta-candidate #1204 +/- ##
======================================================
Coverage 51.44% 51.44%
======================================================
Files 794 794
Lines 131304 131315 +11
======================================================
+ Hits 67549 67558 +9
+ Misses 59576 59573 -3
- Partials 4179 4184 +5 ☔ View full report in Codecov by Sentry. |
* fix: set balance in blockalloc * chg: don't update balance if not zero * fix: lint * fix logic, add test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base branch needs to be changed.
Description
Adds changes back from the reverted PR#1124
Changes:
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it