Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ParallelUniverseBlock from amoyTestnet #1154

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

pratikspatil024
Copy link
Member

Description

Fixed the following error in CI

params/config.go:269:4: unknown field ParallelUniverseBlock in struct literal of type BorConfig

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@pratikspatil024 pratikspatil024 requested a review from a team February 4, 2024 15:26
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (241af1f) 55.92% compared to head (45f6a2a) 55.94%.
Report is 12 commits behind head on develop.

Files Patch % Lines
core/genesis.go 0.00% 13 Missing ⚠️
core/blockchain.go 33.33% 2 Missing ⚠️
params/bootnodes.go 0.00% 2 Missing ⚠️
accounts/keystore/watch.go 0.00% 1 Missing ⚠️
core/txpool/blobpool/limbo.go 50.00% 1 Missing ⚠️
core/vm/interpreter.go 50.00% 1 Missing ⚠️
eth/protocols/eth/dispatcher.go 0.00% 1 Missing ⚠️
internal/flags/helpers.go 0.00% 1 Missing ⚠️
miner/worker.go 0.00% 0 Missing and 1 partial ⚠️
signer/core/api.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1154      +/-   ##
===========================================
+ Coverage    55.92%   55.94%   +0.02%     
===========================================
  Files          658      658              
  Lines       114440   114455      +15     
===========================================
+ Hits         63996    64032      +36     
+ Misses       46601    46564      -37     
- Partials      3843     3859      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pratikspatil024 pratikspatil024 merged commit 08a2608 into develop Feb 5, 2024
13 of 14 checks passed
@pratikspatil024 pratikspatil024 deleted the fix-ci branch February 5, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants