-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fraction Reduction rule #24
Open
justindujardin
wants to merge
17
commits into
master
Choose a base branch
from
feat/fraction-reduction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+832
−1,494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GPT4 generated the test cases, now to implement the rule and verify them one-by-one
- some failures in corner cases, noted in invalid test cases with proper self-shaming commentary
✅ Deploy Preview for friendly-daifuku-ae17d2 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 88.73% 88.89% +0.16%
==========================================
Files 22 23 +1
Lines 2556 2729 +173
==========================================
+ Hits 2268 2426 +158
- Misses 288 303 +15 ☔ View full report in Codecov by Sentry. |
- for rules that might potentially remove variables set this to true to avoid the test suite asserting when it happens.
- i don't remember having to do this. maybe automate it away in the future.
…ault BREAKING CHANGE: prior to this ConstantsSimplify would by default evaluate any fractions it found, yielding a single constant value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
rules
PRs related to implementing rules
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reducing fractions,
layout.render_tree_to_text
utility, and improved error reporting.should probably update the poly simplify generation function to include fractions.
render_tree_to_text
Used for debugging fraction reduction rule errors, generally enriches test assertions: