Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4-beta.3: spacing around sqcup sometimes asymmetrical #3085

Open
pkra opened this issue Aug 15, 2023 · 2 comments
Open

v4-beta.3: spacing around sqcup sometimes asymmetrical #3085

pkra opened this issue Aug 15, 2023 · 2 comments
Labels
Accepted Issue has been reproduced by MathJax team Merged Merged into develop branch Test Needed
Milestone
v4.0

Comments

@pkra
Copy link
Contributor

pkra commented Aug 15, 2023

Apologies for not having a good minimal example.

Take something like $$ \vcenter{\img[][16pt][16pt][]{some.svg}} \sqcup \vcenter{\img[][30pt][30pt][]{another.svg}} \sqcup \vcenter{\img[][58pt][58pt][]{yetanother.svg}} .$$ (using mathjax-img).

In v3, the spacing around \sqcup would be symmetrical:

v3 screenshot with DOM inspector highlights

In v4, the space is asymmetrical:

v4 screenshot with DOM inspector highlights
dpvc added a commit to mathjax/MathJax-src that referenced this issue Aug 15, 2023
@dpvc
Fix spacing before \vcenter, \vtop, \vbox. (mathjax/MathJax#3085)
0e91570
@dpvc dpvc mentioned this issue Aug 15, 2023
Merged
@dpvc dpvc added Ready for Review Accepted Issue has been reproduced by MathJax team Test Not Needed Test Needed and removed Test Not Needed labels Aug 15, 2023
@dpvc
Copy link
Member

dpvc commented Aug 15, 2023

I've made a PR to fix this.

@pkra
Copy link
Contributor Author

pkra commented Aug 16, 2023

I've tested the patch - thank you!

dpvc added a commit to mathjax/MathJax-src that referenced this issue Aug 17, 2023
@dpvc
Merge pull request #990 from mathjax/issue3085
2032f22 
Fix spacing before \vcenter, \vtop, \vbox.  (mathjax/MathJax#3085)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Aug 17, 2023
@dpvc dpvc added this to the v4.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Merged Merged into develop branch Test Needed
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
2 participants
@pkra @dpvc