Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mjx-container is role="presentation" but focusable #2608

Closed
pkra opened this issue Jan 12, 2021 · 1 comment
Closed

mjx-container is role="presentation" but focusable #2608

pkra opened this issue Jan 12, 2021 · 1 comment
Milestone

Comments

@pkra
Copy link
Contributor

pkra commented Jan 12, 2021

The combination of role=presentation and tabindex=0 leads to https://w3c.github.io/aria/#conflict_resolution_presentation_none

f an element is focusable, or otherwise interactive, user agents MUST ignore the presentation role and expose the element with its implicit role, in order to ensure that the element is operable.

This is usually flagged by automated checkers.

It's not a real issue since custom elements have no implicit role worth disabling but for the same reason I don't see why it's added either.

@dpvc
Copy link
Member

dpvc commented Jan 14, 2021

I think we can probably remove the role entirely. This was probably just copied from v2 output that didn't use the custom elements.

@dpvc dpvc added Accepted Issue has been reproduced by MathJax team Ready for Development v3 labels Jan 14, 2021
@dpvc dpvc added this to the 3.1.3 milestone Jan 31, 2021
@dpvc dpvc self-assigned this Jan 31, 2021
dpvc added a commit to mathjax/MathJax-src that referenced this issue Mar 18, 2021
@dpvc dpvc removed their assignment Mar 18, 2021
dpvc added a commit to mathjax/MathJax-src that referenced this issue Mar 19, 2021
Remove role='presentation' attributes.  (mathjax/MathJax#2608)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Mar 19, 2021
@dpvc dpvc added Fixed v3.1 and removed Merged Merged into develop branch labels Apr 27, 2021
@dpvc dpvc closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants