Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add \textup and \textnormal to allowed textmacros. (mathjax/MathJax#2846) #790

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Add \textup and \textnormal to allowed textmacros. (mathjax/MathJax#2846) #790

merged 1 commit into from
Apr 18, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 14, 2022 •
edited
Loading

the \textup and \textnormal macros were left out of textmacros (since they were added after textmacros was created). This PR added them in alongside the other \textXYZ macros.

Resolves issue mathjax/MathJax#2846.

@dpvc dpvc requested a review from zorkow March 14, 2022 19:27
@dpvc dpvc added this to the 3.2.1 milestone Apr 6, 2022
zorkow
zorkow approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit f924d35 into develop Apr 18, 2022
@dpvc dpvc deleted the issue2846 branch April 18, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow