Add support for mglyph use of fontfamily/index. (mathjax/MathJax#2298) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using the
fontfamilyandindexattributes onmglyph, to bring it more in line with v2. This does not do the check that the requested character is actually in the specified font, however, which was done in the HTML-CSS output jax of v2, so thealtattribute will not be used in this case.The common glyph output wrapper now creates a TextNode for the character indicated by
index, and uses that to produce the SVG or CHTML output (and to compute its bounding box).It now reports an error if the
mglyphdoesn't have asrcattribute and is also missing either thefontfamilyorindexattributes.Resolves issue mathjax/MathJax#2298.