Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mml3 filter to an mmlFilter so that forceReparse isn't needed. (mathjax/MathJax#2718) #765

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 30, 2022

This PR move the MML3 filter from being a preFilter to being an mmlFilter. That way it will always run and you don' have to specify forceReparse: true. It also means that (in the browser) you don't have to serialize the math and then re-parse it, as is currently done, since the browser's XSLT parser can work on any DOM fragment. The node version must serialize and re-parse, however.

There is a new enableMml3 configuration option that controls whether the filter is added or not (so that if the extension is packaged with a combined configuration, it can be disabled).

This also make the mmlFilters public, as it should have been originally.

Resolves issue mathjax/MathJax#2718.

@dpvc dpvc requested a review from zorkow January 30, 2022 13:29
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Btw. I could not get mml3 extension to work in the lab yesterday. It could not load the .json file.

@dpvc
Copy link
Member Author

dpvc commented Feb 2, 2022

I could not get mml3 extension to work in the lab yesterday. It could not load the .json file.

It should not be trying to load the .json file, as that should only occur when used in node. It works in the lab for me (using the update-lab branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants