Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-main for webpack 5 #696

Merged
merged 1 commit into from
May 24, 2021
Merged

Update node-main for webpack 5 #696

merged 1 commit into from
May 24, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 6, 2021

This PR updates the webpack.config.js file for the node-main component (which is what you get when you require('mathjax')) to work with the latest version of webpack to which we updated in 3.1.4. This fixes the error that occurs when you do require('mathjax') with the mathjax npm package. (The mathjax-full package works fine because it uses the source version rather than the webpacked version).

Resolves issue mathjax/MathJax#2683.

@dpvc dpvc added this to the 3.2 milestone May 6, 2021
@dpvc dpvc requested a review from zorkow May 6, 2021 10:11
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants