Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the MathDocument reset() command to allow resetting input and output jax. #647

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 22, 2021

As discussed in #570, we wanted a more general reset facility so that you can ask the MathDocument to reset, and it will reset its input and output jax automatically. This PR extends the current reset() method to do that by allowing you to specify what items to be reset. The default is still just the processed bits (since that's what the documented behavior is), but you can request the input or output jax, or all possible resets. It adds the generic reset() methods to the input and output tax objects, and implements them in SVG and CHTML output to reset the font caches, and in TeX input to reset the tags. It updates the Menu code to call the general input-jax reset function rather than including tex-specific code, and it updates the Startup object to create reset commands that use the new generic reset rather than making only a tex-specific one.

@dpvc dpvc requested a review from zorkow March 22, 2021 16:04
Base automatically changed from issue2597 to develop March 22, 2021 16:05
@dpvc dpvc added this to the 3.1.3 milestone Mar 22, 2021
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one whitespace line to remove. O/w lgtm.

@dpvc dpvc merged commit 1261b55 into develop Apr 8, 2021
@dpvc dpvc deleted the general-reset branch April 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants