Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct errors in the horizontal stretchy data for several characters. #645

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 19, 2021

This PR fixes the stretchy data for several characters where it was incorrectly translated from the v2 data. In particular, this fixes the data for \widehat and \widetilde, as well as U+00AF (MACRON) and U+003D (EQUAL SIGN).

See also the comment below for additional changes that were added in a second commit.

@dpvc dpvc requested a review from zorkow March 19, 2021 19:29
@dpvc dpvc added this to the 3.1.3 milestone Mar 19, 2021
@dpvc
Copy link
Member Author

dpvc commented Mar 22, 2021

I've added a commit that fixes additional data (adds the missing variants array for characters that need their schar array to be mapped to non-standard variants). It also fixes the common mo wrapper to actually use the schar array (which was being ignored), which was the cause of mathjax/MathJax#2507, so that issue is fixed by this PR as well.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit b0a451e into develop Mar 29, 2021
@dpvc dpvc deleted the fix-stretchy-data branch March 29, 2021 15:34
@dpvc dpvc changed the title This PR corrects errors in the horizontal stretchy data for several characters. correct errors in the horizontal stretchy data for several characters. Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants