Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully clear tagging on equation start. (mathjax/MathJax#2643) #630

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 16, 2021

This PR resolves an issue where the tagging information was not fully cleared when an equation begins. This caused a problem if there were TagInfo objects on the stack when an extension is autoloaded (causing the equation to be rerendered). The extra TagInfo would end up setting the initial currentTag item when the next equation is processed. See the example at mathjax/MathJax#2643.

@dpvc dpvc added this to the 3.1.3 milestone Mar 16, 2021
@dpvc dpvc requested a review from zorkow March 16, 2021 20:57
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 1b4a161 into develop Mar 29, 2021
@dpvc dpvc deleted the issue2643 branch March 29, 2021 15:13
dpvc added a commit that referenced this pull request Mar 30, 2021
dpvc added a commit that referenced this pull request Apr 9, 2021
Fix regression in tagging caused by #630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants