Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inferred mrows properly (mathjax/MathJax#2624) #585

Closed
wants to merge 1 commit into from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 31, 2021

This PR fixes issue mathjax/MathJax#2624, which is caused by an inferred mrow being included in the internal MathML.

@dpvc dpvc requested a review from zorkow January 31, 2021 13:25
@dpvc dpvc added this to the 3.1.3 milestone Jan 31, 2021
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc
Copy link
Member Author

dpvc commented Feb 9, 2021

I'm looking at making a more general solution (since there are other places this same issue occurs), so I'm going to put this one on hold for the moment.

@dpvc
Copy link
Member Author

dpvc commented Feb 25, 2021

It turns out that #601 resolves this (and other similar issues like mathjax/MathJax#2554) in a more general and straight-forward way, so this PR is no longer needed. I'm closing it for now, but will re-open if #601 is not accepted.

@dpvc dpvc closed this Feb 25, 2021
@dpvc dpvc deleted the issue2624 branch March 8, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants