Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LiteDOM comments and add support for DOCTYPE #523

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 6, 2020

I ran into this while updating the node demos. It turns out that comments were not being output properly from the LiteDOM. I also wanted to be able to preserve the DOCTYPE comment so that the full-page node commands can retain it in their output. So this PR fixes the comment problem, and adds the DOCTYPE support.

@dpvc dpvc requested a review from zorkow July 6, 2020 22:31
@dpvc dpvc added this to the v3.1.0 milestone Jul 6, 2020
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo. O/w lgtm.

@dpvc dpvc merged commit 6bf0ac0 into develop Jul 23, 2020
@dpvc dpvc deleted the liteDOM-update branch July 23, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants