Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sre source location to work in lab as well as node-main and components #521

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix sre source location to work in lab as well as node-main and components #521

merged 1 commit into from
Jul 6, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 25, 2020

This PR fixes the issue with the lab where the enrichment wasn't loading properly, while still allowing node-main to load it.

@dpvc dpvc added this to the v3.1.0 milestone Jun 25, 2020
@dpvc dpvc requested a review from zorkow June 25, 2020 19:34
zorkow
zorkow approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works in my version of the lab! Thanks.

@dpvc dpvc merged commit d4295b9 into develop Jul 6, 2020
@dpvc dpvc deleted the sre-source branch July 6, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow