Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration options to noundefined extension #507

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Add configuration options to noundefined extension #507

merged 2 commits into from
Jun 15, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jun 1, 2020

This PR adds the ability to configure the noundefined extension's colors and size. This brings it in line with the v2 version of the extension.

@dpvc dpvc requested a review from zorkow June 1, 2020 15:58
@dpvc dpvc added this to the v3.1.0 milestone Jun 1, 2020
zorkow
zorkow approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 6ee8276 into develop Jun 15, 2020
@dpvc dpvc deleted the noundefined-config branch June 15, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow