Fix processing of texClass for multi-character <mi> elements. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Jun 15, 2020
Agreed. In fact, this typo was because I thought we were going to camel case, but the TeX input jax retained the original capitalization. Something for the next round of global updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting of
mo.adjustTeXClass()to v3, I messed up these lines. I used the wrong property, (it is capitalized in the two other places it is used), so the if-then was never satisfied. But even if it had been, I set the wrong object's TeX class. This fixes both issues and makes the results consistent with v2.