-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements to input/output errors #491
Conversation
…for the error message, and the same for NoErrors output. Save error messages in input/output data in the MathItem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one problem I see with this use of the title element:
- In CHTML I can see the tooltip. And the title attribute does not interfere with screen reading.
- In SVG the title does not seem to have any effect: There is neither a tooltip nor is it usable as
title
for a screen reader. We could have it as a proper title element, i.e., not just an attribute, but then it would need to be above thearia-hidden
attribute.
It actually already is a It turns out that moving the In CHTML is the tooltip read by screen readers? You say it doesn't interfere, but does that mean it is read or not read? I hadn't intended for it to be read. If you think it needs to be, then we can look into how to address that. I've made a new merge to fix the SVG title issue. See if that works better for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one line to remove. O/w OK.
This PR improves the formatting of 'Math output error' messages (to make them display like other errors, and to allow the contextual menu to be used, and to not cause errors with assistive-mml). The message is also stored in the
inputData
/outputData
object for easier retrieval, if needed.It also adds tooltips to the input and output errors to give the message for the error that occurred, and adds a similar tooltip to the
noerrors
output so that it is easier to get the TeX error that caused the problem. The SVG output jax'smerror
wrapper is modified to move the message to a<title>
element where it will be displayed by the browser as a tool tip.For
noerrors
output, it would be nice to be able to save the message in the MathItem'sinputData
object, but since the TeX input jax'sformatError()
method doesn't have access to the MathItem, that can't be done. It would be nice to change that (see #483).