Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TeX error as data-mjx-error, similar to compile/typeset errors #490

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 13, 2020

This PR adds a data-mjx-error attribute (like the one for compile/typeset errors and like the no errors extension) that contains the error message. This makes the error message consistently available via the data-mjx-error attribute of the merror element, for easier error processing later. (E.g., the contextual menu could use this to report the error.)

…d noerrors extension, so error reporting is consistent
@dpvc dpvc added this to the v3.1.0 milestone May 13, 2020
@dpvc dpvc requested a review from zorkow May 13, 2020 11:50
Base automatically changed from pretty-components to pretty-code May 26, 2020 16:56
@dpvc dpvc changed the base branch from pretty-code to develop May 26, 2020 17:33
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 6ddbcdb into develop Jun 15, 2020
@dpvc dpvc deleted the tex-error-data branch June 15, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants