Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle classList when elements don't have it. (mathjax/MathJax#2411) #489

Merged
merged 1 commit into from
May 26, 2020
Merged

Handle classList when elements don't have it. (mathjax/MathJax#2411) #489

merged 1 commit into from
May 26, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 12, 2020

This uses manipulations of className in place of classList when elements don't have a class list (e.g., IE11 SVG elements). It also fixes an incorrect return type for hasClass() in the interface, and no longer (incorrectly) returns a value for removeClass().

Resolves issue mathjax/MathJax#2411.

@dpvc dpvc added this to the v3.1.0 milestone May 12, 2020
@dpvc dpvc requested a review from zorkow May 12, 2020 18:46
zorkow
zorkow approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Base automatically changed from pretty-components to pretty-code May 26, 2020 16:56
@dpvc dpvc changed the base branch from pretty-code to develop May 26, 2020 17:54
@dpvc dpvc merged commit a6eedb3 into develop May 26, 2020
@dpvc dpvc deleted the issue2411 branch May 26, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow