Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node-main to be able to load SRE more easily #479

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Fix node-main to be able to load SRE more easily #479

merged 3 commits into from
Jun 15, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Apr 26, 2020

This PR sets up the path to SRE properly for node, and gives an asyncLoad command to allow node-main to load SRE when needed. It also moves a copy of a11y/sre-node.js to the es5 directory so that it will be included with the mathjax npm package (it was only available in mathjax-full previously because it was not in the es5 directory).

@dpvc dpvc requested a review from zorkow April 26, 2020 14:15
@dpvc dpvc added this to the v3.1.0 milestone May 8, 2020
zorkow
zorkow approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it works.

@dpvc dpvc merged commit 345d4a2 into develop Jun 15, 2020
@dpvc dpvc deleted the fix-node-main branch June 15, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dpvc @zorkow