Fix problem with \rightarrow being converted to \vec in some cases. (mathjax/MathJax#2380) #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pping to only remap when the (possibly embellished) mo is the only element in the accent position
dpvc
changed the title
zorkow
approved these changes
Apr 6, 2020
| @@ -170,7 +172,7 @@ export class MmlMo extends AbstractMmlTokenNode { | |||
| */ | |||
| get isAccent() { | |||
| let accent = false; | |||
| const node = this.coreParent(); | |||
| const node = this.coreParent().parent; | |||
There was a problem hiding this comment.
The coreParent() call always returns an element (in the code for coreParent() just above this, the embellished operator starts as this, which is non-null, and only gets updated within the loop, where it is set to parent, which is known to be non-null by the condition of the while loop).
While its parent attribute may be null, the next line (just below these comments) checks for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
MmlMo.coreParent()to produce the documented element, and fix accent mapping to only remap when the (possibly embellished)mois the only element in the accent position.Resolves issue mathjax/MathJax#2380.