Update the asyncLoad implementations to be more consistent, and update tests. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the various
asyncLoadimplementations (node,esm, andsystem) operate more consistently, and updates their tests. In particular, relative file names are resolved using therootdirectory, while other names are used as is. That allows using package names likemathjax-full, for example (at least in the implementation where that is possible).In addition, there is a new flag that indicates whether the asyncLoad command is synchronous, use by the font's dynamic file loading command
loadDynamicFilesSync()to determine if it can work or not.There is also a fix to
FontData.jsthat resolves a problem with having removed the.jsfrom file names, which are needed byasyncLoad().The
asyncLoad/node.jsimplementation is modified to be able to be used by both ESM and CJS modules (by calling on the#source/srouce.jsfile to obtain the__dirnamevalue used to construct theroot).Finally, all the tests are updated to include tests for non-relative file names, and for the synchronous flag.