Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by detaching speech computation #1103

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Improve performance by detaching speech computation #1103

merged 4 commits into from
Jun 27, 2024

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Jun 10, 2024

Detaches the speech computation by starting it after the typeset elements are inserted:

  • Introduces a set of timeouts that allow us to
    • to initially delay the computation by 100ms
    • loop through mathitems for ~250ms before breaking
    • for 10ms to allow other processes to come in.
  • Similarly the explorer restarts in case the speech is not yet attached

@zorkow zorkow requested a review from dpvc June 10, 2024 12:06
@dpvc dpvc added this to the v4.0 milestone Jun 11, 2024
@zorkow
Copy link
Member Author

zorkow commented Jun 27, 2024

@dpvc This should be ready to review now.

dpvc
dpvc approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 7733112 into develop Jun 27, 2024
@dpvc dpvc deleted the fix/performance_issues branch June 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpvc dpvc dpvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zorkow @dpvc