Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from #1069 (mathjax/MathJax#3233, mathjax/MathJax#3234) #1094

Closed
wants to merge 1 commit into from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 24, 2024

This PR fixes a regression introduced in #1069 in which primes are misplaced for \underline{x} and give an error about double superscripts for \overline{x} and similar macros. This was du to not taking the subsupOK property in account for these munder and mover constructs. We add those checks here.

Also, this fixes some non-critical number/boolean issues in the base mappings and macros. It works the way it is, but the types are wrong, so we straighten that out here.

Resolves issue mathjax/MathJax#3233 and mathjax/MathJax#3234.

@dpvc dpvc requested a review from zorkow May 24, 2024 18:00
@dpvc dpvc added this to the v4.0 milestone May 24, 2024
@zorkow
Copy link
Member

zorkow commented Jun 4, 2024

Two points:

  • The underlying BaseMethods in develop has now changed significantly, so it might be easier to "replay" the changes in a new branch and create a new PR.
  • It is also likely that the current changes break some of the tests.

@dpvc
Copy link
Member Author

dpvc commented Jun 5, 2024

OK, I have made a new branch and will make a new PR for it, so closing this one.

The tests suggested some additional changes to improve the results, and after that the tests all pass, so don't need modification.

@dpvc dpvc closed this Jun 5, 2024
@dpvc dpvc deleted the issue3233 branch June 5, 2024 12:48
@dpvc dpvc removed this from the v4.0 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants