Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with the new menus (as discussed in our meeting today).
The first is switching the semantic enrichment on and off, which didn't turn on/off the speech and Braille. This was due to now setting the
enableSpeech
,enableBraille
, andenableExplorer
values, which this now does in lines 941 and 942 ofMenu.ts
in thesetAccessibilityMenus()
function. Some initialization was moved from theinitMenu()
function toapplySettings()
(old lines 687 to 689 moved to new 824 to 826, with old lines 837 through 837 being removed, as thesetAccessibilityMenus()
call now sets those values properly.The
enableExplorer
in old line 1004 is not needed, as thesetAccessibilityMenus()
now handled that (new line 942).Old lines 1019 and 1020 are adjusted to avoid running
this.rerender()
twice.The second issue is that the
Hover
andFlame
highlighting options are dependent onCollapsible Math
being set. We talked about disabling these whenCollapsible Math
is unchecked, but since there isn't an obvious connection between the two, this PR instead causesCollapsible Math
to be checked automatically when eitherHover
orFlame
is selected, and the highlighting is reset toNone
ifCollapsible Math
is unchecked. That allows you top select the highlighting witty having to know the connection toCollapsible Math
.Finally, I changed the explicit setter/getter to use
variable()
as we discussed. This seems to work for me, so check if you have any problems.