Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dsfont name in dependencies, and add new fonts to sources #1074

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 10, 2024

This PR fixes a typo in the dsfont name in the dependencies file, and adds the source locations to the source file.

Note that the new font packages are listed in the lab checkboxes, but won't actually work in the lab, since the component files that load the fonts themselves aren't run by the lab when the box is checked. It might be possible to make that work, but I will need to look into it further.

@dpvc dpvc requested a review from zorkow March 10, 2024 14:50
@dpvc dpvc added this to the v4.0 milestone Mar 10, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit b869096 into develop Mar 16, 2024
@dpvc dpvc deleted the ds-font-update branch March 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants