Don't descend into items that aren't broken when looking for the linebreak node. (mathjax/MathJax#3135) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the size of SVG elements for in-lin math when in-line line-breaking is enabled. It fixes the determination of the node where the line breaking occurs by not descending into unbroken nodes. The
bbox.startwas not being properly tested, so it would descending into a fraction, for example, and stop at its numerator, giving the wrong scaling factor when theheightandwidthof the resulting SVG was set.Resolves issue mathjax/MathJax#3135.