Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need better path handling in Windows #398

Closed
dpvc opened this issue Nov 19, 2019 · 0 comments
Closed

Need better path handling in Windows #398

dpvc opened this issue Nov 19, 2019 · 0 comments
Labels
fixed
Milestone
3.0.1

Comments

@dpvc
Copy link
Member

dpvc commented Nov 19, 2019

On Windows, util/asyncLoad/node.js fails because of the expectation at that directory separators are /. Since this is a node-only file, we can use the path built-in node package to handle the path management. See mathjax/MathJax-demos-node#7.
dpvc added a commit that referenced this issue Nov 19, 2019
@dpvc
Use node path module to handle directories, so they work in Windows. …
31abe65 
…Resolves issue #398
@dpvc dpvc mentioned this issue Nov 19, 2019
Merged
@dpvc dpvc self-assigned this Dec 31, 2019
@dpvc dpvc added this to the 3.0.1 milestone Dec 31, 2019
dpvc added a commit that referenced this issue Jan 3, 2020
@dpvc
Merge pull request #399 from mathjax/issue398
4071bf7 
Better path handling.  #398
@dpvc dpvc removed their assignment Feb 5, 2020
@dpvc dpvc added the fixed label Feb 5, 2020
@dpvc dpvc closed this as completed Feb 5, 2020
@snyk-bot snyk-bot mentioned this issue Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
1 participant
@dpvc