Prevent setting a propery that has a getter. (mathjax/MathJax#3098)

mathjax · Sep 14, 2023 · bd03f1c · bd03f1c
1 parent a662fa7
commit bd03f1c
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/ts/components/global.ts b/ts/components/global.ts
@@ -78,18 +78,21 @@ export function isObject(x: any): boolean {
  * Combine user-produced configuration with existing defaults.  Values
  * from src will replace those in dst.
  *
- * @param {any} dst      The destination config object (to be merged into)
- * @param {any} src      The source configuration object (to replace defaul values in dst}
- * @return {any}         The resulting (modified) config object
+ * @param {any} dst         The destination config object (to be merged into)
+ * @param {any} src         The source configuration object (to replace defaul values in dst}
+ * @param {boolean} check   True when combining into MathJax._ to avoid setting getter properties
+ * @return {any}            The resulting (modified) config object
  */
-export function combineConfig(dst: any, src: any): any {
+export function combineConfig(dst: any, src: any, check: boolean = false): any {
   for (const id of Object.keys(src)) {
-    if (id === '__esModule') continue;
+    if (id === '__esModule' || dst[id] === src[id]) continue;
     if (isObject(dst[id]) && isObject(src[id]) &&
         !(src[id] instanceof Promise) /* needed for IE polyfill */) {
-      combineConfig(dst[id], src[id]);
-    } else if (src[id] !== null && src[id] !== undefined && dst[id] !== src[id]) {
-      dst[id] = src[id];
+      combineConfig(dst[id], src[id], check || id === '_');
+    } else if (src[id] !== null && src[id] !== undefined) {
+      if (!check || !Object.getOwnPropertyDescriptor(dst, id)?.get) {
+        dst[id] = src[id];
+      }
     }
   }
   return dst;