Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] specify compatible engines #377

Closed
pkra opened this issue Jan 8, 2018 · 2 comments
Closed

[package] specify compatible engines #377

pkra opened this issue Jan 8, 2018 · 2 comments
Labels
Fixed
Milestone
2.0.0

Comments

@pkra
Copy link
Contributor

pkra commented Jan 8, 2018

Cf. https://docs.npmjs.com/files/package.json#engines

Especially after #325, package.json should specify which versions of node can be used.
@pkra pkra added this to the 2.0.0 milestone Jan 8, 2018
dpvc added a commit that referenced this issue Jan 14, 2018
@dpvc
Add engine dependency (issue #377), and bump version number (issue #325…
0d0c48b 
…).
@dpvc
Copy link
Member

dpvc commented Jan 14, 2018

I've added this to the jsdom10 branch, since it is required for the changes in that branch.

@dpvc
Copy link
Member

dpvc commented Jan 14, 2018

==> Merged.

@dpvc dpvc closed this as completed Jan 14, 2018
@dpvc dpvc added the Fixed label Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@pkra @dpvc