Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the lab to handle the new menu structure #51

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 1, 2024

This PR implements the changes needed to the lab in order to handle the new menu structure in the are-menus branch of Mathjax-src.

@dpvc dpvc requested a review from zorkow March 1, 2024 18:15
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works with the sre-menus branch. I would love to use it to test more thoroughly the combinations for PR 1058, which is a bit of a catch 22. I'll finish that PR as best as possible right now and then once everything is merged I'll tests again.

@dpvc
Copy link
Member Author

dpvc commented Mar 4, 2024

The sre-menus branch is built on top of the fix/ff_safari_issues branch. Is that the problem?

@dpvc
Copy link
Member Author

dpvc commented Mar 8, 2024

I've pushed another commit that fixes a problem where the lab would set both enableSpeech and enableBraille when one or the other is selected. This is why both aria labels were being generated even when only one menu selection was made or one checkbox was selected. So this new commit makes the aria-label and aria-braillelabel work correctly.

(It took me forever to find this, as I thought it was in the menu code, but it was actually in the lab. Argh!)

@dpvc dpvc merged commit 5922496 into v4-lab Mar 8, 2024
@dpvc dpvc deleted the lab-menu-update branch March 8, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants