Correctly open URLs for reading #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add an integration test to prevent future regressions? A test that uses one of the bundled licenses might be enough. |
|
@scordio how about this quick test that the function can indeed read files from jar URLs? |
pschichtel
force-pushed
the
bugfix/headers-from-jars
branch
from
cf3dbb1
to
a715819
Compare
pschichtel
force-pushed
the
bugfix/headers-from-jars
branch
from
a715819
to
4e351ac
Compare
mathieucarbou
approved these changes
May 10, 2024
|
I am out currently - I will be able to issue a new release this weekend with this fix. |
hazendaz
approved these changes
May 10, 2024
pschichtel
force-pushed
the
bugfix/headers-from-jars
branch
from
b72f0a8
to
6c5354f
Compare
Looks good – thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #760