Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logic used to print asterisk for password #718

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Remove logic used to print asterisk for password #718

merged 4 commits into from
Jan 26, 2024

Commits on Jan 26, 2024

  1. [secure] Do not log actual length of password as non readable 

    just send 8 stars instead so it avoids possible invalid usage of regex (was valid here) and there is no real value to how long it really is which sort of gives a hint what it might be at least in length so avoid that altogether.
    @hazendaz
    hazendaz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    45b9995 View commit details
    Browse the repository at this point in the history

  2. [ci] Run password as 5 stars as current test expects that

    @hazendaz
    hazendaz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e0e137c View commit details
    Browse the repository at this point in the history

  3. [test] Stop trying to know the length of a password

    @hazendaz
    hazendaz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e56c6e0 View commit details
    Browse the repository at this point in the history

  4. [cleanup] Remove the printing of password length entirely

    @hazendaz
    hazendaz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8a48340 View commit details
    Browse the repository at this point in the history